-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CXSPA-2067 SSR Logging - Trace Context #17597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Platonn
reviewed
Jul 6, 2023
core-libs/setup/ssr/optimized-engine/optimized-ssr-engine.spec.ts
Outdated
Show resolved
Hide resolved
Platonn
reviewed
Jul 6, 2023
3 flaky tests on run #41541 ↗︎
Details:
cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSRReview all test suite changes for PR #17597 ↗︎ |
Platonn
reviewed
Sep 1, 2023
Platonn
reviewed
Sep 1, 2023
Platonn
reviewed
Sep 1, 2023
Platonn
reviewed
Sep 1, 2023
core-libs/setup/ssr/logger/loggers/w3c-trace-context/parse-traceparent.ts
Outdated
Show resolved
Hide resolved
Platonn
reviewed
Sep 1, 2023
Platonn
reviewed
Sep 6, 2023
Platonn
reviewed
Sep 6, 2023
Platonn
previously approved these changes
Sep 14, 2023
Platonn
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the Trace Context extension, a significant advancement in server-side rendering (SSR) logging. This feature elevates contextual logging by seamlessly incorporating Trace Context parameters into SSR logs.
For detailed information on Trace Context, please refer to the official documentation at https://www.w3.org/TR/trace-context/#overview.
With this pull request, we are now bridging the power of Trace Context to your SSR logs. Our utilities seamlessly map headers to trace context parameters, enabling you to effortlessly expand the context of your SSR logs. This enhancement opens up new possibilities, allowing you to effortlessly connect logs from popular monitoring tools like Kibana to distributed trace presentation tools like Dynatrace.
The following is an example of a log message decorated with the trace context:
closes CXSPA-2067