Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CXSPA-2067 SSR Logging - Trace Context #17597

Merged
merged 31 commits into from
Oct 5, 2023

Conversation

pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Jun 30, 2023

Introducing the Trace Context extension, a significant advancement in server-side rendering (SSR) logging. This feature elevates contextual logging by seamlessly incorporating Trace Context parameters into SSR logs.

For detailed information on Trace Context, please refer to the official documentation at https://www.w3.org/TR/trace-context/#overview.

With this pull request, we are now bridging the power of Trace Context to your SSR logs. Our utilities seamlessly map headers to trace context parameters, enabling you to effortlessly expand the context of your SSR logs. This enhancement opens up new possibilities, allowing you to effortlessly connect logs from popular monitoring tools like Kibana to distributed trace presentation tools like Dynatrace.

The following is an example of a log message decorated with the trace context:

{
  "message": "Rendering completed (/electronics-spa/en/USD/)",
  "context": {
    "timestamp": "2023-09-13T12:14:21.377Z",
    "request": {
      "url": "/electronics-spa/en/USD/",
      "uuid": "a076a5ba-7889-4c19-840e-395e89fde4b5",
      "timeReceived": "2023-09-13T12:14:13.450Z",
      "traceContext": {
        "version": "00",
        "traceId": "0af7651916cd43dd8448eb211c80319c",
        "parentId": "b7ad6b7169203331",
        "traceFlags": "01"
      }
    }
  }
}

closes CXSPA-2067

@cla-assistant
Copy link

cla-assistant bot commented Jun 30, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ pawelfras
✅ giancorderoortiz
✅ Platonn
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@pawelfras pawelfras changed the base branch from develop-6.3.x to develop-6.4.x August 8, 2023 10:18
@pawelfras pawelfras marked this pull request as ready for review August 8, 2023 10:19
@pawelfras pawelfras requested a review from a team as a code owner August 8, 2023 10:19
@github-actions github-actions bot marked this pull request as draft August 8, 2023 10:24
@pawelfras pawelfras marked this pull request as ready for review August 8, 2023 10:24
@cypress
Copy link

cypress bot commented Aug 8, 2023

3 flaky tests on run #41541 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 5d01b6a into 6a8349d...
Project: spartacus Commit: bc76af4424 ℹ️
Status: Passed Duration: 05:31 💡
Started: Oct 5, 2023 11:11 AM Ended: Oct 5, 2023 11:17 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

Review all test suite changes for PR #17597 ↗︎

@github-actions github-actions bot marked this pull request as draft August 9, 2023 11:27
Platonn
Platonn previously approved these changes Sep 14, 2023
@github-actions github-actions bot marked this pull request as draft September 14, 2023 11:31
@pawelfras pawelfras marked this pull request as ready for review September 14, 2023 11:31
@github-actions github-actions bot marked this pull request as draft September 14, 2023 12:51
@pawelfras pawelfras marked this pull request as ready for review September 18, 2023 08:05
@github-actions github-actions bot marked this pull request as draft September 19, 2023 06:28
@pawelfras pawelfras marked this pull request as ready for review September 21, 2023 10:49
@github-actions github-actions bot marked this pull request as draft September 27, 2023 13:50
@pawelfras pawelfras changed the base branch from develop-6.5.x to develop-6.6.x October 4, 2023 11:11
@pawelfras pawelfras dismissed Platonn’s stale review October 4, 2023 11:11

The base branch was changed.

@pawelfras pawelfras marked this pull request as ready for review October 4, 2023 11:11
@github-actions github-actions bot marked this pull request as draft October 4, 2023 11:36
@pawelfras pawelfras marked this pull request as ready for review October 5, 2023 10:27
@github-actions github-actions bot marked this pull request as draft October 5, 2023 10:51
@pawelfras pawelfras marked this pull request as ready for review October 5, 2023 10:56
@pawelfras pawelfras merged commit 68705ca into develop-6.6.x Oct 5, 2023
25 of 26 checks passed
@pawelfras pawelfras deleted the feature/CXSPA-2067 branch October 5, 2023 12:15
@pawelfras pawelfras restored the feature/CXSPA-2067 branch October 5, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants